win, doc: document per-drive current working dir#13330
Closed
bzoz wants to merge 2 commits intonodejs:masterfrom
Closed
win, doc: document per-drive current working dir#13330bzoz wants to merge 2 commits intonodejs:masterfrom
bzoz wants to merge 2 commits intonodejs:masterfrom
Conversation
Add note to fs.md and path.md about Windows using per-drive current working directory. Fixes: nodejs#9378
bzoz
added
doc
addaleax
approved these changes
May 31, 2017
mscdex
added
fs
richardlau
reviewed
May 31, 2017
| <stack trace.> | ||
| ``` | ||
|
|
||
| *Note:* On Windows Node follows the concept of per-drive working directory. |
Member
There was a problem hiding this comment.
Should be Node.js although it's probably enough to just say Windows follows... as Node.js is not doing anything different from the OS behavior.
cjihrig
approved these changes
May 31, 2017
|
|
||
| *Note:* On Windows Node follows the concept of per-drive working directory. | ||
| This behavior can be observed when using a drive path without backslash, e.g. | ||
| `path.resolve('c:\\')` can potentially return different result than |
Contributor
There was a problem hiding this comment.
return different -> return a different
| ``` | ||
|
|
||
| *Note:* On Windows Node follows the concept of per-drive working directory. | ||
| This behavior can be observed when using a drive path without backslash, e.g. |
Contributor
There was a problem hiding this comment.
without backslash -> without a backslash
Trott
reviewed
May 31, 2017
| ``` | ||
|
|
||
| *Note:* On Windows Node follows the concept of per-drive working directory. | ||
| This behavior can be observed when using a drive path without backslash, e.g. |
Member
There was a problem hiding this comment.
Nit: , -> . and e.g. -> For example,.
Trott
reviewed
May 31, 2017
|
|
||
| *Note:* On Windows Node follows the concept of per-drive working directory. | ||
| This behavior can be observed when using a drive path without backslash, e.g. | ||
| `fs.readdirSync('c:\\')` can potentially return different result than |
Member
There was a problem hiding this comment.
return different result -> return a different result
Trott
reviewed
May 31, 2017
| *Note:* On Windows Node follows the concept of per-drive working directory. | ||
| This behavior can be observed when using a drive path without backslash, e.g. | ||
| `fs.readdirSync('c:\\')` can potentially return different result than | ||
| `fs.readdirSync('c:')`. For more information see |
Trott
approved these changes
May 31, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with (or without) nits addressed.
Contributor
Author
|
Updated, PTAL |
gibfahn
approved these changes
Jun 1, 2017
jasnell
approved these changes
Jun 1, 2017
refack
approved these changes
Jun 2, 2017
Contributor
Author
|
Landed in 422722f |
Contributor
Author
3 tasks
Contributor
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add note to
fs.mdandpath.mdabout Windows using per-drive current working directory.Fixes: #9378
Checklist
Affected core subsystem(s)
doc